Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewording facet graphs description #2253

Merged

Conversation

thostetler
Copy link
Member

Changes the wording for the graph facets descriptions (headers)

Adds a couple items to the model, switches the template to use flex and removes moves the text fully to the template.

image
image
image
image

Copy link
Member

@kelockhart kelockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording looks good! Let's double check the math with some testing in dev, but otherwise we're good to go.

@thostetler
Copy link
Member Author

Sounds good. I'll merge and then we can deploy to dev for testing

@thostetler thostetler merged commit 826c1d8 into adsabs:master Sep 16, 2022
@thostetler thostetler deleted the rewording-facet-graphs-description branch September 16, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants