More GA4 Updates #2285
Merged
More GA4 Updates #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thostetler
commented
Feb 15, 2024
thostetler
commented
- Update Gtag on 404 and 500 pages
- Cover additional cases in analytics
- Update analytics calls in Resources
- Fix timing calls
- Consolidate and fix resource quick link calls
- Fix the export component route handler
- Couple of changes to some analytics calls
- Fix bug in classic_form property list
- Attempt to pass a good user_id to GA
thostetler
force-pushed
the
even-more-ga4-events
branch
from
91e1624
to
696a8d1
Compare
shinyichen
reviewed
Feb 16, 2024
Break apart full and data links
Before it didn't properly update the route, now this is fixed.
Decided to just watch the USER_ANNOUNCEMENT event since this should be called by the pubsub after the user is updated. This value must be hashed though to avoid leaking user information, so it may limit to browsers supporting `window.crypto`. @see https://caniuse.com/cryptography Seems like good coverage as of now, so hopefully safe to use this here without polyfills.
thostetler
force-pushed
the
even-more-ga4-events
branch
from
696a8d1
to
d0ecfc8
Compare
shinyichen
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.