Python3 #52
Merged
Python3 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marblestation
requested changes
Jan 19, 2021
There was a problem hiding this comment.
This looks very good! Like for adsabs/graphics_service#95, I have just a couple suggestions:
- I think we can remove some
list(...)that I believe are automatically added by the porting tools but they are not needed when there is an iteration in place. - Let's make travis run the tests with python 3, otherwise we may introduce python 2 code in the future without realizing. This requires changing .travis.yml (example: https://github.com/adsabs/adsabs-pyingest/blob/master/.travis.yml).
| # get metadata for suggestions | ||
| meta_dict = get_meta_data(results=paperFreq[:Nsuggestions]) | ||
| if "Error"in meta_dict: | ||
| return meta_dict | ||
| # return results in required format | ||
| return [{'bibcode': x, 'score': y, 'title': meta_dict[x]['title'], | ||
| 'author':meta_dict[x]['author']} for (x, y) in | ||
| paperFreq[:Nsuggestions] if x in meta_dict.keys()] | ||
| paperFreq[:Nsuggestions] if x in list(meta_dict.keys())] |
There was a problem hiding this comment.
I think this list(...) (automatically added by the porting tools) might not be needed here.
| @@ -72,7 +72,7 @@ def test_config_values(self): | |||
| "CITATION_HELPER_SOLR_PATH", | |||
| "DISCOVERER_PUBLISH_ENDPOINT", | |||
| "DISCOVERER_SELF_PUBLISH"] | |||
| missing = [x for x in required if x not in self.app.config.keys()] | |||
| missing = [x for x in required if x not in list(self.app.config.keys())] | |||
There was a problem hiding this comment.
I think this list(...) (automatically added by the porting tools) might not be needed here.
| # Assert each resource is described has the expected_field | ||
| [self.assertIn(expected_field, v) for v in r.json.values()] | ||
| [self.assertIn(expected_field, v) for v in list(r.json.values())] |
There was a problem hiding this comment.
I think this list(...) (automatically added by the porting tools) might not be needed here.
| # Assert every expected_field has the proper type | ||
| [self.assertIsInstance(v[expected_field], _type) | ||
| for v in r.json.values()] | ||
| for v in list(r.json.values())] |
There was a problem hiding this comment.
I think this list(...) (automatically added by the porting tools) might not be needed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of citation_helper_service to Python 3.8 (according to the "Porting To Python 3" Google Doc)