alembic update #96
alembic update #96
Conversation
ehenneken
commented
Feb 9, 2021
ehenneken
commented
- Cleanup of Alembic configuration
- Addition of two database columns
There was a problem hiding this comment.
It looks good! I am only uncertain about how alembic will behave with the new scripts:
- Revision numbers: I added a small suggestion to make it more in line with what we had before (I believe alembic relies on the revision numbers, so better to conserve what we already had)
- Drop table: Maybe you have already tested that alembic will not drop the table when it will be run in dev/prod, but out of caution (and my own ignorance), I added a comment to double check
These are just suggestions to verify before deployment, so as long as you feel confident with it, we can go ahead!
| def downgrade(): | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| op.drop_index(op.f('ix_graphics_bibcode'), table_name='graphics') | ||
| op.drop_table('graphics') | ||
| # ### end Alembic commands ### |
There was a problem hiding this comment.
This alembic scripts didn't exist before and the only one that existed (revision number 437251c0dc94) has been removed in this PR:
I do not know if alembic will misbehave due to missing revision number + new version scripts and delete the full graphics table. Probably not, but I just wanted to mention that I am not certain. Maybe you have already verified this?
|
|
||
|
|
||
| # revision identifiers, used by Alembic. | ||
| revision = 'c36480cd22db' |
There was a problem hiding this comment.
We had a similar file before that has been deleted instead of moved:
Could we at least rename the new one to match the previous one and change the revision (437251c0dc94 instead of c36480cd22db) to be the same as it was? This will also require to update:
down_revision = 'c36480cd22db'in the file alembic/versions/b9308d306405_create_db_tables.py. This is probably not super important, I am just unsure of the side effects.
