python 3 conversion #36
Conversation
config.py
Outdated
| @@ -32,6 +32,7 @@ | |||
| ADS_TWO_POINT_OH_MIRROR = 'adsabs.harvard.edu' | |||
|
|
|||
| SQLALCHEMY_DATABASE_URI = "" | |||
| SQLALCHEMY_TRACK_MODIFICATIONS = True | |||
There was a problem hiding this comment.
Do we want to enable this tracking? It consumes a lot of overhead. It looks like previously this was set to None by default (https://stackoverflow.com/questions/33738467/how-do-i-know-if-i-can-disable-sqlalchemy-track-modifications), which was equivalent to True. The error can be resolved by setting this to either True, to keep the tracking on, or False.
There was a problem hiding this comment.
somehow I did not get notifications of these comments!
OK, shall change to False.
dev-requirements.txt
Outdated
| coverage==4.5.4 | ||
| flask-testing==0.8.1 | ||
| httmock==1.4.0 | ||
| httpretty==0.8.10; python_version < '3.0' |
There was a problem hiding this comment.
I think we decided to not make the code backwards compatible with Python 2, so you can remove these.
harbour/app.py
Outdated
| @@ -3,19 +3,21 @@ | |||
| Application factory | |||
| """ | |||
|
|
|||
| from future import standard_library | |||
| standard_library.install_aliases() | |||
There was a problem hiding this comment.
These two lines are only needed for Python 2 backwards-compatible code, so you can remove them.
There was a problem hiding this comment.
I think these were added automatically when I run futurize. So you are saying I have to go and remove it from all other ones too, lol.
harbour/client.py
Outdated
| @@ -1,3 +1,4 @@ | |||
| from builtins import object | |||
There was a problem hiding this comment.
Also only needed for Python 2-compatible code.
harbour/utils.py
Outdated
| @@ -19,7 +19,7 @@ def get_post_data(request, types={}): | |||
|
|
|||
| if types and isinstance(post_data, dict): | |||
| for expected_key in types: | |||
| if expected_key not in post_data.keys(): | |||
| if expected_key not in list(post_data.keys()): | |||
There was a problem hiding this comment.
The syntax if key in dict.keys() works ok here in Python 3, without the list() - the converter script is really conservative about adding list() everywhere, even when it's not needed.
There was a problem hiding this comment.
I think this is also part of the futurize! OK, thank you.
harbour/views.py
Outdated
| @@ -2,26 +2,27 @@ | |||
| """ | |||
| Views | |||
| """ | |||
| from future import standard_library | |||
| standard_library.install_aliases() | |||
There was a problem hiding this comment.
These two lines can be removed.
No description provided.