Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color mode, favicon, and switch out youtube embed to use nextjs builtin lib #447

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

thostetler
Copy link
Member

@thostetler thostetler commented Mar 18, 2024

  • flip around the favicon directories light<->dark
    • Now the light directory has the "light" icons and vice versa
  • fix favicon color scheme issue
  • fix color mode issue
  • Change the youtube embed to use nextjs builtin

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 47.6%. Comparing base (5613fb6) to head (114be0f).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #447     +/-   ##
========================================
- Coverage    47.6%   47.6%   -0.0%     
========================================
  Files         405     405             
  Lines       41496   41518     +22     
  Branches      593     594      +1     
========================================
- Hits        19741   19737      -4     
- Misses      21741   21767     +26     
  Partials       14      14             
Files Coverage Δ
src/ssr-utils.ts 39.8% <0.0%> (ø)
src/components/Favicons/Favicons.tsx 2.0% <0.0%> (-8.3%) ⬇️

... and 1 file with indirect coverage changes

@thostetler thostetler merged commit f85f63c into adsabs:master Mar 18, 2024
3 of 4 checks passed
@thostetler thostetler deleted the fix-color-mode-issue branch March 18, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants