Scix 373 Email Notification (formerly myADS) #449
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #449 +/- ##
========================================
- Coverage 47.3% 47.3% -0.0%
========================================
Files 413 425 +12
Lines 41996 44298 +2302
Branches 597 596 -1
========================================
+ Hits 19861 20916 +1055
- Misses 22124 23371 +1247
Partials 11 11
|
| { | ||
| onSettled(data, error) { | ||
| if (error) { | ||
| toast({ status: 'error', title: 'Error', description: parseAPIError(error) }); |
There was a problem hiding this comment.
This should probably be handled slightly differently. Currently the description is not actually getting parsed because it's path is different than the other microservices: (response/data/msg) instead of message -- so we see:
If I fix the parsing:
The error message is worse:
I think, on error here we should probably check if it's syntax issue and alert on the form instead.
There was a problem hiding this comment.
@thostetler Please see my last commit. I added a syntax check.
shinyichen
force-pushed
the
SCIX-373-myads
branch
2 times, most recently
from
d853dc3
to
fb7cea6
Compare
shinyichen
force-pushed
the
SCIX-373-myads
branch
2 times, most recently
from
11af07d
to
aeea656
Compare
shinyichen
force-pushed
the
SCIX-373-myads
branch
from
aeea656
to
b7e0424
Compare
|
@thostetler Updated to check the validity of keyword. Let me know if it looks good to go. |
Screen.Recording.2024-03-19.at.11.40.33.AM.mov