Update the API request timeouts for SSR #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinyichen
approved these changes
Mar 22, 2024
Changed the serverside API call timeout to 1.5 seconds (down from 30 seconds, 5% of the clientside calls) Clientside should refetch it and show a loading state if the query fails to load in time. This timeout value will need to be tested, but the percieved speed is definitely improved with a short server-side timeout. For URL array params switch from `repeat` to `comma` and update tests that broke.
thostetler
force-pushed
the
alter-ssr-async-timeouts
branch
from
a050db3
to
17f553c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #454 +/- ##
========================================
+ Coverage 47.6% 47.6% +0.1%
========================================
Files 405 405
Lines 41518 41558 +40
Branches 594 597 +3
========================================
+ Hits 19737 19760 +23
- Misses 21767 21784 +17
Partials 14 14
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the serverside API call timeout to 1.5 seconds (down from 30 seconds, 5% of the clientside calls) Clientside should refetch it and show a loading state if the query fails to load in time.
This timeout value will need to be tested, but the percieved speed is definitely improved with a short server-side timeout.
This also fixes the array formatting so the params don't repeat in the url