SCIX-311 default collection not applied

[thostetler]

Adds All to the default databases.
Gets default databases working on new searches

Improves logging and error handling in query-utils

[codecov]

Codecov Report

Attention: Patch coverage is 57.81250% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 47.5%. Comparing base (168ed86) to head (ce8b0ee).

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #456     +/-   ##
========================================
- Coverage    47.6%   47.5%   -0.0%     
========================================
  Files         405     409      +4     
  Lines       41614   41858    +244     
  Branches      596     600      +4     
========================================
+ Hits        19773   19857     +84     
- Misses      21830   21990    +160     
  Partials       11      11             

Files	Coverage Δ
src/api/user/models.ts	100.0% <100.0%> (ø)
src/api/user/types.ts	100.0% <100.0%> (ø)
...itationExporter/components/DescriptionCollapse.tsx	96.8% <100.0%> (+0.3%)	⬆️
src/components/SearchFacet/YearHistogramSlider.tsx	25.6% <100.0%> (ø)
src/components/Settings/Search/Description.tsx	100.0% <100.0%> (ø)
src/query.ts	96.9% <ø> (-<0.1%)	⬇️
...isualizations/Containers/OverviewPageContainer.tsx	23.0% <50.0%> (ø)
src/auth-utils.ts	45.7% <0.0%> (-1.3%)	⬇️
src/query-utils.ts	88.2% <45.0%> (-10.1%)	⬇️

... and 4 files with indirect coverage changes

[shinyichen]

A question: is the 'All' option necessary? Is it just convenience? Or does All include things beyond the specified categories?

If I selected all categories but not 'All', is it equivalent to selecting 'All' ?

[thostetler]

A question: is the 'All' option necessary? Is it just convenience? Or does All include things beyond the specified categories?

If I selected all categories but not 'All', is it equivalent to selecting 'All' ?

I agree, I think it's just a way of explicitly saying you want to NOT apply any filters.
And yeah AFAIK all of these are the same:

• ALL selected (resulting in no collections applied)
• None selected (resulting in DEFAULT -- but in this case none -- collections applied)
• All collections selected (resulting in an OR'd filter including all the collections)

I think the point is to allow users to explicitly set their intention here. In Nectar, right now we don't have any global default filters, so it doesn't change anything to set ALL -- but if we did, then this would explicitly say we want NO filters applied.