Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update abstract sources UI #467

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

shinyichen
Copy link
Member

@shinyichen shinyichen commented Apr 4, 2024

Update UI for abstract full text and other sources :

  • In desktop, it is moved to the left side, and is always visible while navigating within the article
Screenshot 2024-04-05 at 4 13 11 PM
  • In mobile, it is unchanged
Screenshot 2024-04-05 at 4 14 18 PM

@shinyichen shinyichen marked this pull request as ready for review April 4, 2024 20:58
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 53.58255% with 149 lines in your changes are missing coverage. Please review.

Project coverage is 47.4%. Comparing base (bd67d7c) to head (86c84f9).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #467     +/-   ##
========================================
- Coverage    47.5%   47.4%   -0.1%     
========================================
  Files         409     413      +4     
  Lines       41858   41970    +112     
  Branches      599     596      -3     
========================================
- Hits        19857   19856      -1     
- Misses      21990   22103    +113     
  Partials       11      11             
Files Coverage Δ
src/components/icons/GenericFileIcon.tsx 66.7% <66.7%> (ø)
src/components/icons/HtmlFileIcon.tsx 66.7% <66.7%> (ø)
src/components/icons/PdfFileIcon.tsx 60.0% <60.0%> (ø)
src/components/Layout/AbsLayout.tsx 25.0% <27.3%> (-1.6%) ⬇️
src/components/AbstractSources/AbstractSources.tsx 65.6% <54.8%> (-10.4%) ⬇️
...components/AbstractSources/AbstractSourceItems.tsx 52.5% <52.5%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how I feel about this menu pushing the navigation down, but it does work to make it more prominent on the page. If Kelly is cool with this then I'm good too.

@shinyichen
Copy link
Member Author

I'm not sure how I feel about this menu pushing the navigation down, but it does work to make it more prominent on the page. If Kelly is cool with this then I'm good too.

I feel the same, but Alberto came up with it, and it might be better than the other designs.

@shinyichen shinyichen merged commit c04a1dc into adsabs:master Apr 10, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants