Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scix 407 lib sort date added #468

Merged
merged 7 commits into from
Apr 15, 2024

Conversation

shinyichen
Copy link
Member

Sort library documents by date added, this is the default sort for library documents

Screenshot 2024-04-11 at 2 17 39 PM

@shinyichen shinyichen marked this pull request as ready for review April 11, 2024 21:18
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 35.84906% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 47.3%. Comparing base (86c84f9) to head (b077706).
Report is 2 commits behind head on master.

❗ Current head b077706 differs from pull request most recent head 1872aa2. Consider uploading reports for the commit 1872aa2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #468     +/-   ##
========================================
- Coverage    47.4%   47.3%   -0.0%     
========================================
  Files         413     413             
  Lines       41970   41996     +26     
  Branches      596     597      +1     
========================================
+ Hits        19856   19861      +5     
- Misses      22103   22124     +21     
  Partials       11      11             
Files Coverage Δ
src/api/biblib/types.ts 100.0% <100.0%> (ø)
src/components/Sort/model.ts 100.0% <100.0%> (ø)
src/utils.ts 68.6% <50.0%> (-0.1%) ⬇️
src/components/Sort/Sort.tsx 22.8% <42.9%> (-0.8%) ⬇️
src/components/Libraries/LibraryEntityPane.tsx 12.4% <9.1%> (-0.3%) ⬇️

Copy link
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me, I think as an alternative we could pull out the list (and types) of the component and make it the parent's responsibility. But this solution looks okay for now, and is simpler in this case, if a little less flexible.

src/utils.ts Outdated Show resolved Hide resolved
@shinyichen
Copy link
Member Author

This looks okay to me, I think as an alternative we could pull out the list (and types) of the component and make it the parent's responsibility. But this solution looks okay for now, and is simpler in this case, if a little less flexible.

Agreed. I didn't like the idea of mixing biblib sort with the rest of the solr sorts, but didn't want to mess up the current setup. I will commit this first, and start working on the refactor as well.

shinyichen and others added 2 commits April 15, 2024 11:27
Co-authored-by: Tim Hostetler <6970899+thostetler@users.noreply.github.com>
@thostetler thostetler force-pushed the SCIX-407-lib-sort-date-addeds branch from c9513d2 to 0031280 Compare April 15, 2024 19:35
@thostetler thostetler force-pushed the SCIX-407-lib-sort-date-addeds branch from 0031280 to 1872aa2 Compare April 15, 2024 19:41
@shinyichen shinyichen merged commit e965dec into adsabs:master Apr 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants