-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scix 407 lib sort date added #468
Scix 407 lib sort date added #468
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #468 +/- ##
========================================
- Coverage 47.4% 47.3% -0.0%
========================================
Files 413 413
Lines 41970 41996 +26
Branches 596 597 +1
========================================
+ Hits 19856 19861 +5
- Misses 22103 22124 +21
Partials 11 11
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay to me, I think as an alternative we could pull out the list (and types) of the component and make it the parent's responsibility. But this solution looks okay for now, and is simpler in this case, if a little less flexible.
Agreed. I didn't like the idea of mixing biblib sort with the rest of the solr sorts, but didn't want to mess up the current setup. I will commit this first, and start working on the refactor as well. |
Co-authored-by: Tim Hostetler <6970899+thostetler@users.noreply.github.com>
c9513d2
to
0031280
Compare
0031280
to
1872aa2
Compare
Sort library documents by date added, this is the default sort for library documents