Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display user name if logged in #471

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

shinyichen
Copy link
Member

Screenshot 2024-04-24 at 3 32 04 PM Screenshot 2024-04-24 at 3 32 23 PM

@shinyichen shinyichen marked this pull request as ready for review April 24, 2024 22:33
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 47.3%. Comparing base (a910341) to head (1c7081c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #471     +/-   ##
========================================
- Coverage    47.4%   47.3%   -0.0%     
========================================
  Files         425     425             
  Lines       44363   44389     +26     
  Branches      597     597             
========================================
+ Hits        20986   20988      +2     
- Misses      23366   23390     +24     
  Partials       11      11             
Files Coverage Δ
src/components/NavBar/types.tsx 100.0% <100.0%> (ø)
src/components/NavBar/MenuDropdown.tsx 15.0% <7.5%> (-4.3%) ⬇️

Copy link
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shinyichen shinyichen merged commit 03ec2d9 into adsabs:master Apr 25, 2024
3 of 4 checks passed
@shinyichen shinyichen deleted the SCIX-405-show-username branch April 25, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants