Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility fixes #476

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

shinyichen
Copy link
Member

@shinyichen shinyichen commented May 7, 2024

  • Aria label
    • Removed aria-labeledby in most <FormControl> since <FormLabel> sets htmlFor for children input.
    • Except for the Switch component which requires a label.
  • Fixed contrasts
  • Improved keyboard accessibility

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 15.41667% with 203 lines in your changes are missing coverage. Please review.

Project coverage is 47.2%. Comparing base (b077706) to head (4ec6ebd).
Report is 45 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #476     +/-   ##
========================================
- Coverage    47.3%   47.2%   -0.1%     
========================================
  Files         413     425     +12     
  Lines       41996   44488   +2492     
  Branches      597     596      -1     
========================================
+ Hits        19861   20967   +1106     
- Misses      22124   23510   +1386     
  Partials       11      11             
Files Coverage Δ
src/components/BibstemPicker/BibstemPicker.tsx 65.4% <100.0%> (+0.2%) ⬆️
src/components/DataDownloader/DataDownloader.tsx 100.0% <100.0%> (+2.4%) ⬆️
src/components/Expandable/Expandable.tsx 89.3% <100.0%> (ø)
...c/components/NavigationMenu/SideNavigationMenu.tsx 17.8% <ø> (+0.2%) ⬆️
...rc/components/SearchBar/AllSearchTermsDropdown.tsx 52.6% <100.0%> (+0.4%) ⬆️
src/components/Slider/Slider.tsx 64.9% <100.0%> (+0.2%) ⬆️
...izations/Containers/AuthorNetworkPageContainer.tsx 22.0% <ø> (+0.1%) ⬆️
...lizations/Containers/PaperNetworkPageContainer.tsx 23.4% <ø> (+0.1%) ⬆️
...lizations/Containers/ResultsGraphPageContainer.tsx 15.6% <ø> (+0.2%) ⬆️
src/pages/paper-form.tsx 73.0% <100.0%> (-1.2%) ⬇️
... and 32 more

... and 12 files with indirect coverage changes

@shinyichen shinyichen requested a review from thostetler May 7, 2024 21:18
@shinyichen shinyichen marked this pull request as ready for review May 20, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant