Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix facet filter not applied #496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shinyichen
Copy link
Member

Fix bug where only first search filter is applied. The query doesn't work correctly when the format of the array fq param is comma, but works if format is repeat.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.3%. Comparing base (b46de25) to head (0c48a8d).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #496     +/-   ##
========================================
- Coverage    47.3%   47.3%   -0.0%     
========================================
  Files         427     427             
  Lines       44836   44846     +10     
  Branches      624     624             
========================================
- Hits        21197   21196      -1     
- Misses      23627   23638     +11     
  Partials       12      12             
Files Coverage Δ
src/api/config.ts 69.3% <100.0%> (ø)
src/utils.ts 85.8% <100.0%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant