Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial fixes for partition problem #35

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

ehenneken
Copy link
Member

This fixes the problem with the surprising results of the round() function in Python 3.8 versus Python 2.7. E.g. round(12.5) evaluates to 12 in the Python 3.8 version, while it evaluates to 13 in the Python 2.7 version. This causes different data going into the augment_graph_data function. With the implemented fix, the data remains the same in both versions up to the point where the network is partitioned. With the current fix, results are still different after the partitioning at https://github.com/adsabs/vis-services/blob/master/vis_services/lib/paper_network.py#L95. No idea how to fix this.

Copy link
Contributor

@marblestation marblestation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks for investing time investigating this!

@ehenneken ehenneken merged commit a28cddc into adsabs:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants