Initial fixes for partition problem #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem with the surprising results of the
round()
function in Python 3.8 versus Python 2.7. E.g.round(12.5)
evaluates to12
in the Python 3.8 version, while it evaluates to13
in the Python 2.7 version. This causes different data going into theaugment_graph_data
function. With the implemented fix, the data remains the same in both versions up to the point where the network is partitioned. With the current fix, results are still different after the partitioning at https://github.com/adsabs/vis-services/blob/master/vis_services/lib/paper_network.py#L95. No idea how to fix this.