feat(websocket): switch to nhooyr.io/websocket for wasm support #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- KeepAlive heartbeat implemented using nhooyr/websocket#265 (comment) - Only spot websocket API switched to nhooyr websocket atm - Close the websocket using StatusNormalClosure
|
Hi @Milerius , thanks for this PR. It looks good to me, I will build and test it in my environment to check if everything works. |
adshao
previously approved these changes
Jul 29, 2021
|
Hi @Milerius , I have tested it, it seems great. Could you please refactor for delivery and futures packages as well? |
Sure i will do shortly. |
adshao
approved these changes
Jul 29, 2021
adshao
added a commit
that referenced
this pull request
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is achievied:
I do not that have that much experience with golang & websocket, i tested my implementation, it works for me but I don't know if it was the most idiomatic way to do it, feel free to comment and give your opinion so that we can move in the right direction.
It is especially the first time that I have to use a context and I have a little doubt about the lifespan of the context in this specific case, I tried not to break the architecture in place (2 chans quit / done) but suddenly I don't know if on the lifetime side the cancel function of the context will still be available at the time of the websocket closure.
cc @adshao
Address #284
Motivation for this pr: I am currently writing a trading bot that also works in webassembly, having the websocket binance would allow me to have the prices in real time rather than having to do polling in my browser