Fix components changing their own props

aduh95 · Aug 6, 2019 · 43d5616 · 43d5616
1 parent d6600a6
commit 43d5616
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/src/Editor.js b/src/Editor.js
@@ -18,6 +18,7 @@ export default class Editor extends Component {
    * @param {MutationObserver} observer
    */
   handleMutation(mutationList, observer) {
+    let rebuildDOM = false;
     const data = this.#DOMData;
     for (const mutation of mutationList) {
       const { target, type } = mutation;
@@ -75,12 +76,13 @@ export default class Editor extends Component {
               obj[key] = undefined;
             });
             Object.assign(obj, JSON.parse(target.dataset.json));
+            rebuildDOM = true;
           }
           break;
       }
     }
 
-    this.props.onChange(data.get(this), false);
+    this.props.onChange(data.get(this), rebuildDOM);
   }
 
   observeNode(node) {

diff --git a/src/components/AsideList.js b/src/components/AsideList.js
@@ -9,8 +9,6 @@ export default class AsideList extends Component {
       writeMode: false,
       data: JSON.stringify(data),
     });
-
-    Object.assign(this.props, data);
   }
 
   render() {

diff --git a/src/components/NewsletterArticle.js b/src/components/NewsletterArticle.js
@@ -52,8 +52,6 @@ export default class NewsletterArticle extends Component {
       writeMode: false,
       data: JSON.stringify(data),
     });
-
-    Object.assign(this.props, data);
   }
 
   render() {