For Y2K38 on 32 bit systems time_t tv_sec can be long long
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @robert-scheck it indeed makes sense on modern system. I'll merge on current HEAD. Thanks a lot. |
|
That's a good idea especially to quickly spot anything wrong in new contribution. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully properly fix what CodeQL analysis spotted in #67. However, please review carefully!
I am not a C programmer or expert, but from my understanding,
time_t tv_seccan be up tolong long, e.g. on OpenBSD to cover Y2K38 compatibility on 32 bit systems. At https://man.openbsd.org/clock_gettime.2#EXAMPLES, there is an example, which this pull request is inspired from.See also: https://lists.samba.org/archive/samba-technical/2015-September/109355.html