Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function for utf-16 compression #9

Merged
merged 4 commits into from
Jan 18, 2021

Conversation

fxwiegand
Copy link
Contributor

@fxwiegand fxwiegand commented Jan 11, 2021

This PR adds a function analog to this one that compresses to utf-16 encoding. Our project would benefit from having this function available directly from the crate and hopefully others will too. Please let me know if you need any changes, more tests or even the decompress method for example.

Since char::from_u32 is still unstable (see rust-lang/rust#71763) it could take some time before this can be merged.

@adumbidiot
Copy link
Owner

Hi, thanks for the PR!

While the associated function char::from_u32 is not stable, the function std::char::from_u32 is. I'll be happy to merge this if you could make that small change.

@fxwiegand
Copy link
Contributor Author

Hi, thanks for the PR!

While the associated function char::from_u32 is not stable, the function std::char::from_u32 is. I'll be happy to merge this if you could make that small change.

Oh that is good to know! I think everything should good now.

@adumbidiot adumbidiot merged commit 3859b6c into adumbidiot:master Jan 18, 2021
@adumbidiot
Copy link
Owner

Thanks!

@fxwiegand fxwiegand deleted the add_utf16_compression branch July 22, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants