Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug][safari] Carts are not displayed properly #85

Closed
FaberVitale opened this issue Sep 13, 2021 · 6 comments · Fixed by #213
Closed

[bug][safari] Carts are not displayed properly #85

FaberVitale opened this issue Sep 13, 2021 · 6 comments · Fixed by #213

Comments

@FaberVitale
Copy link
Contributor

Carts are not displayed correctly on safari.

Safari left side.
Chrome right side.

Screenshot 2021-09-13 at 16 48 55

@christopher-kleine
Copy link
Contributor

Carts are not displayed correctly on safari.

When in doubt, blame Safari first.

Since I had a chance to bash Safari, let's focus on the issue:
Did you check the properties of the canvas? Like width, height etc?
I can't, since I'm no Mac user.

@FaberVitale
Copy link
Contributor Author

FaberVitale commented Sep 13, 2021

@christopher-kleine

aspect-ratio: 1 / 1 defined in .game-enabled does not work.
We should probably fallback to something more compatible.

@aduros
Copy link
Owner

aduros commented Sep 13, 2021

There are a couple issues with mobile Safari:

  1. No CSS aspect-ratio support, although it looks like it's being added in iOS 15: https://developer.apple.com/documentation/safari-release-notes/safari-15-beta-release-notes

  2. No Fullscreen API support on iPhone (only iPad). We wait for the first tap on the game to fullscreen it for a better experience on mobile. I guess a workaround could be either expanding the iframe on wasm4.org to 100% on a tap, or popping it open in a new window.

@joshgoebel
Copy link
Contributor

We should probably fallback to something more compatible.

Agree. Is the website FOSS as well? Would a PR be welcome? I'm seeing this on desktop Safari as well (haven't tried mobile)... I thought something was badly broken.

@aduros
Copy link
Owner

aduros commented Dec 16, 2021

The website is in this repo under /site, PRs to fix the sizing without using aspect-ratio would be very welcome!

The relevant CSS is in /site/src/css/custom.css.

@FaberVitale
Copy link
Contributor Author

FaberVitale added a commit to FaberVitale/wasm4 that referenced this issue Dec 19, 2021
FaberVitale added a commit to FaberVitale/wasm4 that referenced this issue Dec 19, 2021
aduros added a commit that referenced this issue Dec 20, 2021
fix(site): incorrect cart layout in iOS devices #85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants