Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tone panning (solves #320) #330

Merged
merged 7 commits into from
Mar 23, 2022
Merged

Tone panning (solves #320) #330

merged 7 commits into from
Mar 23, 2022

Conversation

JerwuQu
Copy link
Contributor

@JerwuQu JerwuQu commented Jan 16, 2022

馃巿

Needs:

  • Porting to web APU
  • Documentation
  • New slider in Sound Test Tool
  • Test ScriptProcessor
  • Test Worklet

@netlify
Copy link

netlify bot commented Jan 16, 2022

鉁旓笍 Deploy Preview for wasm4 ready!

馃敤 Explore the source changes: 865b8e9

馃攳 Inspect the deploy log: https://app.netlify.com/sites/wasm4/deploys/61e433c893201c000861c924

馃槑 Browse the preview: https://deploy-preview-330--wasm4.netlify.app

@joshgoebel
Copy link
Contributor

I'm not sure "panning" is the right name though if we aren't actually panning from left to right... and it's just "which channel to play this on".

@JerwuQu
Copy link
Contributor Author

JerwuQu commented Jan 16, 2022

I think panning is the most commonly used term for this, despite it only being hard left, or hard right.

Looking at different resources for the Gameboy as example, they also uses "panning" as the term.

Examples:

Copy link
Owner

@aduros aduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried it yet, but looks great! I like that setting both PAN_LEFT and PAN_RIGHT is the same as no panning.

runtimes/web/src/apu-worklet.ts Outdated Show resolved Hide resolved
runtimes/native/src/apu.c Outdated Show resolved Hide resolved
JerwuQu and others added 2 commits March 23, 2022 13:30
Co-authored-by: Bruno Garcia <b@aduros.com>
Co-authored-by: Bruno Garcia <b@aduros.com>
@aduros aduros merged commit 5d147a5 into aduros:main Mar 23, 2022
@JerwuQu JerwuQu deleted the tone-panning branch March 23, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants