Change Rust template static muts to consts #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes the FRAMEBUFFER and PALETTE variables in the Rust template from "pub static mut" to "pub const", as the pointers themselves don't ever need to be mutated or have a static memory address.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the FRAMEBUFFER and PALETTE variables in the Rust template from
pub static muttopub const, as the pointers themselves don't ever need to be mutated or have a static memory address.In the future, we may be able to have the framebuffer directly like this:
pub static mut FRAMEBUFFER: [u8; 6400] = unsafe { *(0xa0 as *mut [u8; 6400]) };but this isn't stablised yet.