Initial changes to support easy hosting of site and netplay connection server #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
closed this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the idea of making it easy for others to host the site/netplay server is appealing, I could write up documentation and flesh this out more. I don't expect or want this PR to be accepted in its current state; I'm looking for feedback on whether this is a project goal or not.
I made some basic changes that allow users to easily host the site and netplay server that connects peers together. This includes adding a Dockerfile and example docker-compose file. I wasn't really able to find any documentation about this side of WASM-4, and if the aduros.com or wasm4.org websites go down then WASM-4 netplay stops working unless there are other signal servers being run.
These changes were the bare minimum I needed to get things working in a testing environment. I have another branch where I removed more of the site and made further changes needed for me to re-host, but I don't think any of that is useful upstream. There's plenty of things to improve here: not running the site from "docusaurus serve" in the Dockerfile and making it easier to configure the new "$HOSTNAME" are obvious places to start and there are several other changes that would make this more generally useful.