Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in C template and added C++ template #634

Closed
wants to merge 2 commits into from
Closed

Fix a bug in C template and added C++ template #634

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 31, 2023

  • Fix the bug in the C template
  • Simplified the C template
  • Separate the C++ procedure into its template

@ghost
Copy link
Author

ghost commented Mar 31, 2023

Also, issue #268 can be closed once this pr is merged, although the C++ template documentation is TODO.

aduros
aduros reviewed Apr 2, 2023
View reviewed changes
cli/assets/templates/c/Makefile
build/cart.wasm: $(OBJECTS)
$(CXX) -o $@ $(OBJECTS) $(LDFLAGS)
all:
@mkdir -p build
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't mkdir -p not work on Windows?

@ghost ghost closed this by deleting the head repository May 6, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@aduros