Make the invite link work for html bundles #647
Conversation
leighmcculloch
changed the title
|
@aduros What do you think? |
|
@aduros If there's an alternative way you'd like addressing this issue approached, I'm happy to have a go of that too. |
|
This sounds good to me, but I think we need a special case for the games hosted on https://wasm4.org/play. |
|
What's the best way to signal that to the code generating the bundle? |
|
A command line option? |
|
I don't think we need a new param. The easiest way might be to branch on |
|
That's a trivial change. I can make that. |
|
I've made the change so that the original URL is preserved for file, localhost, and wasm4.org. On other domains it uses the existing URL. |
|
I'm not sure if something is up with the signal server, but this was working a little while ago, but today the netplay URL is just a blank screen. There's no errors. I see the connection to the signal server is the last thing to happen and then the game never starts 🤔. Did anything change on the backend side? |
|
PR looks great, but is the new link not working on the connecting side? Nothing should have changed on the backend. Can you share a link? If you think it was just a network hiccup, I can just merge this 🙂 |
|
I think it was just a network hiccup, or environmental issue, as I hadn't changed anything meaningful relating to netplay. |
|
It must be my network, because the netplay on wasm4.org with games hosted there is broken for me too. But it was working a couple weeks ago. But regardless, this change is independent of that issue I'm seeing. |
|
@aduros Wdyt, mergeable? |
|
Sounds good! Thanks. |
What
Make the invite link the same URL that the game is being displayed from with the netplay peer ID parameter, instead of a link to wasm4.org/netplay.
Why
When bundling wasm4 games as HTML, it's an odd user experience that invite links take players off to another website.