Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framebuffer refactorings #79

Merged
merged 4 commits into from
Sep 14, 2021
Merged

Framebuffer refactorings #79

merged 4 commits into from
Sep 14, 2021

Conversation

MaxGraey
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Sep 12, 2021

✔️ Deploy Preview for wasm4 ready!

🔨 Explore the source changes: ac6caa8

🔍 Inspect the deploy log: https://app.netlify.com/sites/wasm4/deploys/6140666546ba030007ad9649

😎 Browse the preview: https://deploy-preview-79--wasm4.netlify.app

@eXponenta
Copy link
Contributor

Fixing a #11 will be nice addition for this PR

@aduros
Copy link
Owner

aduros commented Sep 13, 2021

Looking good to me, thanks for the needed cleanup!

I wonder about the inlining of drawPoint, is it possible to do it in a way that doesn't sacrifice readability too much?

@MaxGraey
Copy link
Contributor Author

MaxGraey commented Sep 13, 2021

is it possible to do it in a way that doesn't sacrifice readability too much?

Basic idea is manually hoist all invariants out of loop, not just inline drawPoint. Basically browser should do this by itself but it's not always happening. I could just revert this inlines back if readability is more preffered

@aduros
Copy link
Owner

aduros commented Sep 13, 2021

Ok, let's revert the inlining for readability for now. I'd like to do the C port, fix bugs (#11), and add missing functionality (#13) before we go too far with optimization.

@MaxGraey MaxGraey changed the title refactorings & optimizations for framebuffer Framebuffer refactorings Sep 14, 2021
@MaxGraey
Copy link
Contributor Author

Done!

@aduros
Copy link
Owner

aduros commented Sep 14, 2021

Thanks!

@aduros aduros merged commit f2be427 into aduros:main Sep 14, 2021
@MaxGraey MaxGraey deleted the optimize-drawings branch September 14, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants