Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify different colors for own messages and their timestamps. #382

Open
wants to merge 59 commits into
base: main
Choose a base branch
from

Conversation

j4hangir
Copy link

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

@antoine92190
Copy link
Collaborator

Could you please checkout the dist files? I will update those for the next release

@j4hangir
Copy link
Author

Could you please checkout the dist files? I will update those for the next release

I think it's through, although one more thing is missing which is the me color for timestamps.

BTW I think it would've been much more convenient to use CSS parts, allow people to apply their css without the hassle of defining each and every variable.

@j4hangir
Copy link
Author

j4hangir commented Nov 8, 2022

I've replaced the audio recorder with capacitor-voice-recorder which is also web-friendly allowing iOS to use VAC as well.

I've merely replaced the relevant parts in recorder.js and did some patching with Audio/Video detection code - which on a side-note is quite bug-prone! - but it works nicely so far, although replacing hardcoded .mp3 with .wav will cause problems down the line.

Please have a look and if you approve of this direction I'll tidy up and get rid of the old one completely.

@antoine92190
Copy link
Collaborator

This looks promising, but it's very difficult to see the code changes as your code formatting tool changed indentation.

  • Could you revert the code formatting changes and the dist files so it's easier to read?
  • It would be nice to create another PR as this one should only focus on message color and timestamp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants