Merge pull request #11 from advanced-rest-client/fix/W-15791262/clien…

…t-secret-optional-field Fix/w-15791262/client secret optional field
advanced-rest-client · May 31, 2024 · efb52d0 · efb52d0
2 parents f40c557 + 898e534
commit efb52d0
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@advanced-rest-client/authorization",
   "description": "The UI and logic related to HTTP authorization.",
-  "version": "0.1.11",
+  "version": "0.1.12",
   "license": "Apache-2.0",
   "main": "index.js",
   "module": "index.js",

diff --git a/src/Oauth2MethodMixin.js b/src/Oauth2MethodMixin.js
@@ -170,8 +170,8 @@ const mxFunction = (base) => {
     }
 
     get oauth2ClientSecretRequired() {
-      const { grantType } = this;
-      return ['authorization_code'].includes(grantType);
+      const { grantType, pkce } = this;
+      return ['authorization_code'].includes(grantType) && !pkce;
     }
 
     get oauth2AuthorizationUriRendered() {

diff --git a/src/Validation.js b/src/Validation.js
@@ -91,8 +91,8 @@ export const validateOauth2AuthImplicit = (element) => {
  * @return {Boolean} Validation result
  */
 export const validateOauth2AuthCode = (element) => {
-  const { clientId, clientSecret, authorizationUri, accessTokenUri } = element;
-  return !!clientId && !!authorizationUri && !!clientSecret && !!accessTokenUri;
+  const { clientId, clientSecret, authorizationUri, accessTokenUri, pkce = false } = element;
+  return !!clientId && !!authorizationUri && !!accessTokenUri && (!!clientSecret || pkce);
 };
 
 /**