feat: navigate to column on top of line

[adrienpessu]

This pull request primarily includes changes to the SarifService and SarifViewerWindowFactory classes in the sarifviewer package to enhance the handling of source code locations. The changes involve the addition of column information to the Leaf class and the openFile method, and an adjustment to the column number in the openFile method.

Here are the key changes:

Changes to the SarifService class:

• src/main/kotlin/com/github/adrienpessu/sarifviewer/services/SarifService.kt: The Leaf object now includes column information in the address and steps fields. Previously, these fields only contained the URI and start line. Now, they also include the start column, providing more precise location information. If the start column is not available, it defaults to 0.

Changes to the SarifViewerWindowFactory class:

• src/main/kotlin/com/github/adrienpessu/sarifviewer/toolWindow/SarifViewerWindowFactory.kt: The openFile method now accepts an additional parameter for the column number. This change is reflected where the method is invoked, such as in the mouseClicked event and when opening a file. The column number passed to openFile is now extracted from the address field of the currentLeaf object.
• src/main/kotlin/com/github/adrienpessu/sarifviewer/toolWindow/SarifViewerWindowFactory.kt: The column number passed to the navigate method of the FileEditorManager instance is reduced by 1 to correctly align with the zero-based indexing of columns in the editor.

[github-actions]

Qodana Community for JVM

17 new problems were found

Inspection name	Severity	Problems
Incorrect string capitalization	🔶 Warning	3
Redundant SAM constructor	🔶 Warning	2
Local 'var' is never modified and can be declared as 'val'	🔶 Warning	1
Unused symbol	🔶 Warning	1
Property naming convention	◽️ Notice	6
Unnecessary parentheses in function call with lambda	◽️ Notice	2
Object literal can be converted to lambda	◽️ Notice	1
Accessor call that can be replaced with property access syntax	◽️ Notice	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

1. Register at Qodana Cloud and configure the action
2. Use GitHub Code Scanning with Qodana
3. Host Qodana report at GitHub Pages
4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.2
        with:
          upload-result: true

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions