Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mirv_viewmodel to AfxHookSource2 #955

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

ChetdeJong
Copy link
Contributor

Closes #941

Give it a check though. Maybe at very least you want to rename things/put in slightly different way

@dtugend
Copy link
Member

dtugend commented Jun 21, 2024

Hi. Thanks for your contribution. I will have to look into the hook signatures you use in order to add some comments in the code or in doc/ folder of what these functions are and how to find them, because the signatures will probably break with the next larger CS2 update :S
Also if they are part of a vtable, it might be easier and more stable to use that to find them, but maybe they are not (didn't check yet).
I will try to do these tasks before Sunday (unless there's urgent CS2 update breakage of course).

@ChetdeJong
Copy link
Contributor Author

ChetdeJong commented Jun 21, 2024

well, these two are pretty straight forward I think, but I don't know if they are part of vtable or not.

Only thing is for some reason your FindPatternString can't find full pattern for second function (ghidra can find it though). So I shorten it a touch, but it's still unique.

Full signature for left/right hand function I got generated with sigga is 40 56 48 83 EC 20 80 B9 69 21 00 00 00 48 8B F1 ? ? 32 C0 48 83 C4 20 5E ? 48 8B 89.

@dtugend
Copy link
Member

dtugend commented Jun 21, 2024

(You need to put two question marks for a byte in FindPatternString , since it's for hex string, 2 hex digits are a byte.)

@ChetdeJong
Copy link
Contributor Author

ye actually, I overlooked that. Works with full one

@dtugend dtugend merged commit 97af73b into advancedfx:main Jun 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CS2: mirv_viewmodel
2 participants