Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests failing on stackage #44

Open
cdornan opened this issue Nov 13, 2023 · 2 comments
Open

tests failing on stackage #44

cdornan opened this issue Nov 13, 2023 · 2 comments

Comments

@cdornan
Copy link

cdornan commented Nov 13, 2023

We are seeing this failure on stackage-nightly (ghc-9.6.3):

     Test suite failure for package markov-chain-usage-model-0.0.0
           markov-chain-usage-model-test:  exited with: ExitFailure 1
       Full log available at /home/curators/work/unpack-dir/.stack-work/logs/markov-chain-usage-model-0.0.0-test.log


           test/Spec.hs
             Unit
               expectExpectedArcReliability: OK
               expectTransientReliability:   OK
               occurenceMean:                OK
               occurenceVar:                 OK
               docTest:                      src/MarkovChain.hs:94: failure in expression `fundamental (minorMatrix 5 5 p :: M)'
           expected: ┌                                                                                 ┐
                     │                 1.0  1.2307692307692306  1.2307692307692308  0.9230769230769231 │
                     │                 0.0  1.2307692307692306  1.2307692307692308  0.9230769230769231 │
                     │                 0.0 0.15384615384615385  2.1538461538461537  0.6153846153846154 │
                     │                 0.0  0.3076923076923077  0.3076923076923077  1.2307692307692308 │
                     └                                                                                 ┘
            but got: ┌                                                                                 ┐
                     │                 1.0  1.2307692307692308  1.2307692307692308  0.9230769230769231 │
                                                             ^
                     │                 0.0  1.2307692307692308  1.2307692307692308  0.9230769230769231 │
                     │                 0.0 0.15384615384615385  2.1538461538461537  0.6153846153846154 │
                     │                 0.0  0.3076923076923077  0.3076923076923077  1.2307692307692308 │
                     └                                                                                 ┘

           src/MarkovChain.hs:112: failure in expression `occVariance (fundamental (minorMatrix 5 5 p :: M))'
           expected: ┌                                                                                 ┐
                     │                 0.0 0.28402366863905315  2.5562130177514795  0.4970414201183433 │
                     │                 0.0 0.28402366863905315  2.5562130177514795  0.4970414201183433 │
                     │                 0.0 0.20118343195266267  2.4852071005917153  0.5207100591715977 │
                     │                 0.0  0.3550295857988165  0.9230769230769231  0.2840236686390534 │
                     └                                                                                 ┘
            but got: ┌                                                                                 ┐
                     │                 0.0  0.2840236686390534  2.5562130177514795  0.4970414201183433 │
                                           ^
                     │                 0.0  0.2840236686390534  2.5562130177514795  0.4970414201183433 │
                     │                 0.0 0.20118343195266275  2.4852071005917153  0.5207100591715977 │
                     │                 0.0  0.3550295857988166  0.9230769230769231  0.2840236686390534 │
                     └                                                                                 ┘

           src/MarkovChain.hs:131: failure in expression `perron p'
           expected: [0.1857142857142857,0.22857142857142854,0.22857142857142856,0.17142857142857143,0.1857142857142857]
            but got: [0.1857142857142857,0.22857142857142856,0.22857142857142856,0.17142857142857143,0.1857142857142857]
                                                           ^

           src/MarkovChain.hs:157: failure in expression `:{
           let s :: M
               s = fromList 4 5
                 [ 1,    0,    0,    0,    0
                 , 0,    0.5,  0.5,  0,    0
                 , 0,    0.5,  0.25, 0.25, 0
                 , 0.25, 0,    0,    0.5,  0.25
                 ]
           in sigma s (perron p)
           :}'
           expected: [0.2807017543859649,0.2807017543859649,0.21052631578947367,0.17543859649122806,5.2631578947368425e-2]
            but got: [0.2807017543859649,0.2807017543859649,0.2105263157894737,0.17543859649122806,5.2631578947368425e-2]
                                                                             ^

           Examples: 11  Tried: 11  Errors: 0  Failures: 4
           FAIL
                 Exception: ExitFailure 1
                 Use -p '/docTest/' to rerun this test only.

           1 out of 5 tests failed (1.59s)

We have marked the suite as expected-test-failures for now.

@stevana
Copy link
Contributor

stevana commented Nov 14, 2023

Hmm, that's rather odd -- it seems that basic operations on doubles yield slightly different results, no clue why. Anyway, I think this package shouldn't be on stackage. I assume it's there only because quickcheck-state-machine depends on it?

stevana added a commit to stevana/quickcheck-state-machine that referenced this issue Nov 15, 2023
* Remove `markov-chain-usage-model` dependency and the related
  `Test.StateMachine.Markov` module. The tests of the dependency started
  failing:
  advancedtelematic/markov-chain-usage-model#44 , and
  I don't think anyone is using that functionality anyway, so I decided to
  remove it (please let me know if this breaks your tests);

* Disable `ProcessRegistry` test for now, the generator needs to be migrated
  away from using the removed `Markov` module;

* Remove RQLite test as it was causing build issues with newer versions of GHC;

* Add support for newer versions of GHC (9.0.2, 9.2.8, 9.4.7, and 9.6.3);

* Remove stack support;

* Add nix support;

* Add back CI support via GitHub Actions (remove old travis config).
stevana added a commit to stevana/quickcheck-state-machine that referenced this issue Nov 15, 2023
* Remove `markov-chain-usage-model` dependency and the related
  `Test.StateMachine.Markov` module. The tests of the dependency started
  failing:
  advancedtelematic/markov-chain-usage-model#44 , and
  I don't think anyone is using that functionality anyway, so I decided to
  remove it (please let me know if this breaks your tests);

* Disable `ProcessRegistry` test for now, the generator needs to be migrated
  away from using the removed `Markov` module;

* Remove RQLite test as it was causing build issues with newer versions of GHC;

* Add support for newer versions of GHC (9.0.2, 9.2.8, 9.4.7, and 9.6.3);

* Remove stack support;

* Add nix support;

* Add back CI support via GitHub Actions (remove old travis config).
@stevana
Copy link
Contributor

stevana commented Nov 17, 2023

I've just release quickcheck-state-machine-0.8.0 which doesn't depend on markov-chain-usage-model, so the latter can now be removed from stackage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants