networkd-dhcp-conf: fix REQUIRED_DISTRO_FEATURES #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* it's REQUIRED_DISTRO_FEATURES not REQUIRED_DISTRO_FEATURES_ * inherit features_check to actually respect REQUIRED_DISTRO_FEATURES and fix: ERROR: networkd-dhcp-conf-1.0-r1 do_package_qa: QA Issue: networkd-dhcp-conf: recipe doesn't inherit features_check [unhandled-features-check] * fix: commit 4ae9917 Author: Mykhaylo Sul <ext-mykhaylo.sul@here.com> Date: Fri Nov 1 11:44:44 2019 +0100 OTA-3988: Don't build the networkd-dhcp recipe if systemd is not included into the disto feature list Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
|
Good catches, thanks! It's annoying, though, that the docs still list |
pattivacek
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
The same flaky tests failed (https://main.gitlab.in.here.com/olp/edge/ota/connect/client/meta-updater/-/pipelines/1064001) but otherwise this looks fine, so I'm merging it.
|
Thanks. Yes the documentation should be better updated, but at least there is this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's REQUIRED_DISTRO_FEATURES not REQUIRED_DISTRO_FEATURES_
inherit features_check to actually respect REQUIRED_DISTRO_FEATURES
and fix:
ERROR: networkd-dhcp-conf-1.0-r1 do_package_qa: QA Issue: networkd-dhcp-conf: recipe doesn't inherit features_check [unhandled-features-check]
fix:
commit 4ae9917
Author: Mykhaylo Sul ext-mykhaylo.sul@here.com
Date: Fri Nov 1 11:44:44 2019 +0100
OTA-3988: Don't build the networkd-dhcp recipe if systemd is not included into the disto feature list
Signed-off-by: Martin Jansa Martin.Jansa@gmail.com