Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FVTR] gccgo test is failing on pcc64 for AT >= 10.0 #143

Closed
rzinsly opened this issue Aug 9, 2017 · 1 comment · Fixed by #578
Closed

[FVTR] gccgo test is failing on pcc64 for AT >= 10.0 #143

rzinsly opened this issue Aug 9, 2017 · 1 comment · Fixed by #578
Assignees
Labels

Comments

@rzinsly
Copy link
Member

rzinsly commented Aug 9, 2017

The gccgo test is failing on AT 11.0 when built for ppc64 (BE):
gccgo: power8: Running gccgo package test...
t^M
Hello!^M
fatal error: unexpected signal during runtime execution^M
gccgo: power8: gccgo test failed

By manually running we got the following errors:
./gopkgtest
Hello!
fatal error: unexpected signal during runtime execution
[signal SIGSEGV: segmentation violation code=1 addr=1731642852816977920 pc=70367025496785]

goroutine 16 [running]:
runtime.dopanic
/home/rzinsly/AT/tmp/at11.0-0-beta1.redhat-7_ppc64_ppc64/sources/gcc/libgo/go/runtime/panic.go:832
runtime.throw
/home/rzinsly/AT/tmp/at11.0-0-beta1.redhat-7_ppc64_ppc64/sources/gcc/libgo/go/runtime/panic.go:758
runtime.sigpanic
/home/rzinsly/AT/tmp/at11.0-0-beta1.redhat-7_ppc64_ppc64/sources/gcc/libgo/go/runtime/signal_unix.go:241
runtime.sighandler
/home/rzinsly/AT/tmp/at11.0-0-beta1.redhat-7_ppc64_ppc64/sources/gcc/libgo/go/runtime/signal_sighandler.go:59
runtime.sigtrampgo
/home/rzinsly/AT/tmp/at11.0-0-beta1.redhat-7_ppc64_ppc64/sources/gcc/libgo/go/runtime/signal_unix.go:227

    :0

    :0

    :0

    :0

time.formatNano
/home/rzinsly/AT/tmp/at11.0-0-beta1.redhat-7_ppc64_ppc64/sources/gcc/libgo/go/time/format.go:403
time.AppendFormat.N9_time.Time
/home/rzinsly/AT/tmp/at11.0-0-beta1.redhat-7_ppc64_ppc64/sources/gcc/libgo/go/time/format.go:612
time.Format.N9_time.Time
/home/rzinsly/AT/tmp/at11.0-0-beta1.redhat-7_ppc64_ppc64/sources/gcc/libgo/go/time/format.go:457
time.String.N9_time.Time
/home/rzinsly/AT/tmp/at11.0-0-beta1.redhat-7_ppc64_ppc64/sources/gcc/libgo/go/time/format.go:428
main.main
/home/rzinsly/AT/tmp/fvtr/gccgo/testpkg.go:33

    :0

    :0

    ../sysdeps/unix/sysv/linux/powerpc/powerpc64/makecontext.S:136

    :0

goroutine 17 [syscall]:
goroutine in C code; stack unavailable

goroutine 18 [finalizer wait]:

    :0

    :0

    :0

    :0

    ../sysdeps/unix/sysv/linux/powerpc/powerpc64/makecontext.S:136

    :0

goroutine 19 [runnable]:

    :0

    :0

    :0

    ../sysdeps/unix/sysv/linux/powerpc/powerpc64/makecontext.S:136

    :0
@rzinsly rzinsly added the bug label Aug 9, 2017
@tuliom tuliom self-assigned this Jul 23, 2018
@tuliom
Copy link
Contributor

tuliom commented Jul 23, 2018

The cause of this issue is a misconfiguration of GCC that disables split-stack in all tuned libraries:

cc1: error: '-fsplit-stack' currently only supported on PowerPC64 GNU/Linux with glibc-2.18 or later
cc1: error: '-fsplit-stack' is not supported by this compiler configuration

I'm preparing a fix.

tuliom added a commit to tuliom/advance-toolchain that referenced this issue Jul 23, 2018
GCC cannot recognize the correct glibc version when configured without
--with-glibc-version, causing split-stack to be disabled.  The default
builds already use this parameter, but the tuned libraries were left
behind.
This patch also improves the gccgo test to validate if split-stack was
enabled in its shared libraries.
Fixes issue advancetoolchain#143.

Signed-off-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
@tuliom tuliom mentioned this issue Jul 24, 2018
tuliom added a commit that referenced this issue Jul 27, 2018
GCC cannot recognize the correct glibc version when configured without
--with-glibc-version, causing split-stack to be disabled.  The default
builds already use this parameter, but the tuned libraries were left
behind.
This patch also improves the gccgo test to validate if split-stack was
enabled in its shared libraries.
Fixes issue #143.

Signed-off-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
tuliom added a commit to tuliom/advance-toolchain that referenced this issue Aug 1, 2018
This patch backports a fix from AT 11.0 to AT 10.0 that enables
split-stack in GCC tuned libraries.
As both stage files became identical, the AT 11.0 file was replaced with
a symlink.

Closes advancetoolchain#143.

Signed-off-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
@tuliom tuliom changed the title [FVTR] gccgo test is failing on pcc64 for AT 11.0 [FVTR] gccgo test is failing on pcc64 for AT >= 10.0 Aug 2, 2018
tuliom added a commit that referenced this issue Aug 3, 2018
This patch backports a fix from AT 11.0 to AT 10.0 that enables
split-stack in GCC tuned libraries.
As both stage files became identical, the AT 11.0 file was replaced with
a symlink.

Closes #143.

Signed-off-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants