Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AGS Editor Sprite View remember folder tree area size #1484

Open
ericoporto opened this issue Jan 7, 2022 · 2 comments
Open

Make AGS Editor Sprite View remember folder tree area size #1484

ericoporto opened this issue Jan 7, 2022 · 2 comments
Labels
context: ui/ux type: enhancement a suggestion or necessity to have something improved what: editor related to the game editor

Comments

@ericoporto
Copy link
Member

I have an issue that barely qualifies as a nitpick, but rather a small annoyance that I wonder if anything could be done about. I've been organizing all my sprites into folders and subfolders. This means I have to increase the window size to accommodate the expanded folder trees in the "select a sprite to use" window. Normally that's no big deal, but the window size resets to the original (too small) size every time I want to select a sprite. Is there any way the size of this window can be "saved" so I don't need to do that every time? See the image below to see what I mean.

image

Originally from here: https://www.adventuregamestudio.co.uk/forums/index.php?topic=59607.0

@ivan-mogilko ivan-mogilko added context: ui/ux type: enhancement a suggestion or necessity to have something improved what: editor related to the game editor labels Jan 8, 2022
@ivan-mogilko
Copy link
Contributor

ivan-mogilko commented Jan 8, 2022

This suggests that this size should be saved somewhere in memory, at least. But probably it also suggests that it should be saved between the sessions?

I guess there are two tasks:

  1. Investigate if this may be done uniformly for any similar windows (how many floating resiable windows do we have in the Editor though? maybe not a lot); like have some kind of a gui manager that saves this kind of information in memory, and provides to opened windows on demand.
  2. Investigate how to save this on disk. This is not a project data, so should be part of either app settings, or "layout". The docking panels layout is currently read from a file (layout.xml) by the layout manager, but it's possible that it expects all file be its own and not containing anything extra. In such case there may be a separate file for saving additional windows.

Note that the saved data primarily includes the window size, but it may additionally have other values, like the splitter position, or zoom level.

Maybe this information could be kept as a dictionary per window, where keys and values are defined by the window itself (as it knows what it needs). Then this dictionary is serialized to XML, like everything else in the editor.

@ericoporto
Copy link
Member Author

This specific component is used in two different places, alone in it's own panel, and in this sprite selection window. I think it's own panel is usually open and kept open, but this sprite selection window is open and closed everytime a new sprite has to be selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context: ui/ux type: enhancement a suggestion or necessity to have something improved what: editor related to the game editor
Projects
None yet
Development

No branches or pull requests

2 participants