Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGS 4: Room editor does not respect game's color depth when creating/importing backgrounds #2218

Closed
ivan-mogilko opened this issue Nov 8, 2023 · 3 comments
Labels
ags 4 related to the ags4 development context: editor assets related to input files for editing the game context: graphics mode type: bug unexpected/erroneous behavior in the existing functionality what: editor related to the game editor

Comments

@ivan-mogilko
Copy link
Contributor

Describe the bug
If you have a 8-bit or 16-bit color depth game, then:

  • creating a new room will generate a 32-bit bg.
  • when importing a bg even of proper color depth, editor will still save it as 32-bit png.

It's still possible to place a 8-bit png into the Rooms/n/ folder directly, but I suspect that if editor will ever resave it, it will still use 32-bit format.

Also, 8-bit room bgs are not displayed in the game as they should, it looks like room bgs colors are not applied to the "Background" palette slots, and room instead uses colors from default palette. But this may be an unrelated issue.

AGS Version
4.0.0.1

Expected behavior
Imported room backgrounds should be stored converted to the game's color depth. When room is created programmatically (blank template) the bg should have the game's color depth.

@ivan-mogilko ivan-mogilko added context: graphics what: editor related to the game editor ags 4 related to the ags4 development context: editor assets related to input files for editing the game labels Nov 8, 2023
@ivan-mogilko ivan-mogilko added this to the 4.0.0 (preliminary) milestone Nov 8, 2023
@ivan-mogilko ivan-mogilko added type: bug unexpected/erroneous behavior in the existing functionality context: graphics mode and removed context: graphics labels Nov 8, 2023
@ivan-mogilko ivan-mogilko changed the title AGS 4: Room editor does not respect game's color depth wen creating/importing backgrounds AGS 4: Room editor does not respect game's color depth when creating/importing backgrounds Nov 8, 2023
@ivan-mogilko
Copy link
Contributor Author

Confirmed fixed by #2354

@ivan-mogilko
Copy link
Contributor Author

ivan-mogilko commented Mar 15, 2024

Reopened as not completely fixed yet, specifically this part:

Also, 8-bit room bgs are not displayed in the game as they should, it looks like room bgs colors are not applied to the "Background" palette slots, and room instead uses colors from default palette. But this may be an unrelated issue.

It appears that these bgs look fine in the Editor for whatever reason, but they are broken at runtime.

@ivan-mogilko
Copy link
Contributor Author

Fixed by #2393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ags 4 related to the ags4 development context: editor assets related to input files for editing the game context: graphics mode type: bug unexpected/erroneous behavior in the existing functionality what: editor related to the game editor
Projects
None yet
Development

No branches or pull requests

1 participant