Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: reimplement WorkspaceState.RequiresRebuild in a user-friendly way #2357

Open
ivan-mogilko opened this issue Mar 15, 2024 · 1 comment
Labels
ags3 related to ags3 (version with full backward compatibility) ags 4 related to the ags4 development context: ui/ux type: enhancement a suggestion or necessity to have something improved what: editor related to the game editor

Comments

@ivan-mogilko
Copy link
Contributor

Since certain version Editor marks an imported old project as "requires full rebuild". This mark is serialized in workspace settings, and is only reset on complete successful compilation. This condition is problematic, because the project may contain numerous issues that have to be resolved after upgrade, but this mark will force Editor to rebuild every single room each time. This makes step by step fix of the project rather tedious, as you have to wait when all rooms are recompiled again each time (and might seem confusing to users as well).

My proposal is to invent a more user friendly method. For instance, Editor could save a list of things needed to be rebuilt instead (rooms etc) and remove items from this list as they are built successfully at least once.

I believe this has to be done both in ags4 and ags3.

@ivan-mogilko ivan-mogilko added type: enhancement a suggestion or necessity to have something improved what: editor related to the game editor ags 4 related to the ags4 development ags3 related to ags3 (version with full backward compatibility) context: ui/ux labels Mar 15, 2024
@ivan-mogilko ivan-mogilko added this to the 4.0.0 (preliminary) milestone Mar 15, 2024
@AlanDrake
Copy link
Contributor

True, it's a bit annoying when compiling room scripts and the compiler gets stuck at every single error.

Perhaps it's possible to resume a previous compilation process that was interrupted due to a room. If there were no changes to headers and previous rooms I might expect they're fine.
Or all scripts could be compiled in memory while delaying the room packaging only after a successful compilation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ags3 related to ags3 (version with full backward compatibility) ags 4 related to the ags4 development context: ui/ux type: enhancement a suggestion or necessity to have something improved what: editor related to the game editor
Projects
None yet
Development

No branches or pull requests

2 participants