Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illegal Exception in No-Action Jackson #2366

Closed
tag2015 opened this issue Mar 26, 2024 · 3 comments
Closed

Illegal Exception in No-Action Jackson #2366

tag2015 opened this issue Mar 26, 2024 · 3 comments
Assignees

Comments

@tag2015
Copy link
Contributor

tag2015 commented Mar 26, 2024

Describe the bug
No-Action Jackson crashes with an Illegal exception right after the intro (intro can be skipped pressing ESC)

An exception 0xC0000005 occurred in ACWIN.EXE at EIP = 0x004951DA; program pointer is +6, engine version 3.6.0.57, gtags (0,12)
CrashInfo.3.6.0.57.dmp

AGS Version
Latest 3.6.0/3.6.1

Game
https://archive.org/details/No-Action_Jackson

To Reproduce
Steps to reproduce the behavior:

  1. Start game
  2. Wait (or skip) intro

Desktop
Win10

@ivan-mogilko ivan-mogilko self-assigned this Mar 26, 2024
@ivan-mogilko
Copy link
Contributor

ivan-mogilko commented Mar 26, 2024

This seems to happen when hovering a cursor over certain areas on the game screen. For some reason the "GetHotspotProperty" is called with -1 index.

EDIT: checking much older engine (around v3.4.4), it seems like this was happening all the time, but it somehow managed to "get away with this" because data had a different memory layout previously.

EDIT2: this starts crashing engines since v3.5.0, somehow nobody noticed this until now...

@ivan-mogilko ivan-mogilko added this to the 3.6.0 maintenance milestone Mar 26, 2024
@ivan-mogilko
Copy link
Contributor

Pushed a fix: 99f94c4

@tag2015
Copy link
Contributor Author

tag2015 commented Mar 27, 2024

Thanks for the quick fix! Confirmed working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants