Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huggingface spaces web demo #13

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Huggingface spaces web demo #13

merged 1 commit into from
Oct 26, 2021

Conversation

AK391
Copy link
Contributor

@AK391 AK391 commented Oct 16, 2021

easy to use web demo using gradio on huggingface spaces

@senya-ashukha
Copy link
Collaborator

Hi @AK391,

Thank you for making this demo! I think an auto-generation of masks is a great idea.
Is it possible to add also a mask painting option? It might be great to give a user a choice.

@AK391
Copy link
Contributor Author

AK391 commented Oct 18, 2021

@senya-ashukha yes there is a gradio sketchpad input in image components https://gradio.app/docs where a user can draw the mask but it wont be overlayed with the original image and will show separately in the interface

@AK391
Copy link
Contributor Author

AK391 commented Oct 20, 2021

@senya-ashukha added a mask painting option check it out https://huggingface.co/spaces/akhaliq/lama
Screen Shot 2021-10-20 at 5 57 34 PM

@senya-ashukha
Copy link
Collaborator

@AK391 that is great, thank you! But the mask and results are squeezed compared to the original image. It is possible to correct this?

@AK391
Copy link
Contributor Author

AK391 commented Oct 21, 2021

@senya-ashukha Hi the mask and input image are resized so that they match, unfortunately the mask currently cant be overlayed over the original image due to how the canvas input component works in gradio.

@senya-ashukha
Copy link
Collaborator

senya-ashukha commented Oct 21, 2021

Hi @AK391,

  1. No overlapping, get it, it is fine!
  2. But I believe the final image and the mask are squeezed and have a different size and aspect ratio. It does not look good IMO(
  3. Let's also show a masked image on the right instead of just a mask?

Screenshot 2021-10-21 at 10 50 52

@AK391
Copy link
Contributor Author

AK391 commented Oct 21, 2021

@senya-ashukha adding changes to keep aspect ratio
for 3 do you mean overlay the mask on top of the image to show on the right?
Screen Shot 2021-10-21 at 11 46 28 AM

@senya-ashukha
Copy link
Collaborator

senya-ashukha commented Oct 21, 2021 via email

@senya-ashukha senya-ashukha merged commit 8f3e784 into advimman:main Oct 26, 2021
@senya-ashukha
Copy link
Collaborator

senya-ashukha commented Oct 26, 2021

Hi @AK391,

Thank you for making the great demo! I think the possible correction is minor anyway!
I've merged but moved the link to "Non-official 3rd party apps" section. And also I've added your account name next to it. Let me know if any correction is needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants