Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to add new tools? #19

Closed
rik43 opened this issue Aug 1, 2019 · 6 comments · Fixed by #41
Closed

how to add new tools? #19

rik43 opened this issue Aug 1, 2019 · 6 comments · Fixed by #41
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rik43
Copy link

rik43 commented Aug 1, 2019

is it possible?

@nilsE
Copy link

nilsE commented Aug 7, 2019

would like to do that, too

@advoor
Copy link
Owner

advoor commented Sep 16, 2019

@rik43 @nilsE , have a look at: bbbdd69

Basic steps are really, add the new tool to the package.json, and then add the relevant config in FormField.vue.

The output of the tool should then be handled in 'src/NovaEditorJs.php'. The above commit is a perfect example.

What tool are you looking to implement? I can potentially look at integrating some more tools

@roelofr
Copy link
Collaborator

roelofr commented Oct 5, 2019

Basic steps are really, add the new tool to the package.json, and then add the relevant config in FormField.vue.

Sadly this stops users from being able to fluently update their dependencies and add support for new fields. It would be awesome if some kind of hook-form could be worked out (maybe make the EditorJs macroable?)

I'll try to puzzle something together next week, because I too want to add a bunch of in-house tools.

@advoor
Copy link
Owner

advoor commented Oct 14, 2019

@roelofr If you can, it would be awesome! I've not had any time at all recently to work on this, so any help is greatly appreciated!

roelofr pushed a commit that referenced this issue Nov 17, 2019
@roelofr roelofr self-assigned this Nov 17, 2019
@roelofr roelofr added the enhancement New feature or request label Nov 17, 2019
@roelofr roelofr mentioned this issue Nov 17, 2019
4 tasks
@roelofr
Copy link
Collaborator

roelofr commented Nov 17, 2019

For now I figured out a possible way to solve this, but I'm absolutely not sure about this method, since it requires Javascript that changes stuff on the window.

However, as Nova doesn't re-compiles assets, I'm very afraid it's the only plausible method to use...
Look into #33 for more information, and please discuss the fix there.

@roelofr roelofr added the help wanted Extra attention is needed label Nov 17, 2019
@TheDeadCode
Copy link
Contributor

See #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
5 participants