Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to heading and update editor-js and plugins #99

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

miagg
Copy link

@miagg miagg commented Jun 12, 2023

This PR will:

  • Update editor-js to the latest version (v2.27.0)
  • Update plugins
  • Fix issue with heading that could not been converted to paragraph
  • Fix issue with inlineTool not being displayed on heading
  • Add support for levels and defaultLevel configuration options on header tool.
  • Fix appearance issues on new version
  • Add dark mode support

This will fix #92 and #53 .

@@ -5,10 +5,19 @@
border-width: 1px;
border-color: #bacad6;
padding-left: .75rem;
color: #7c858e;
color: #6b7280;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're changing the hex value, why not change it to a var(...)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I had variables but I had to fix several inconsistencies and vars didn't work for me.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this alphabetically made it quick to find what blocks were available.
What is the benefit of changing this to a seemingly-random order?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to resemble the official editorjs order (based on most common use) here.
I think user will benefit more from this order, since there is no way to custom order them using the configuration file.

@@ -1,4 +1,4 @@
const EditorJS = require('@editorjs/editorjs');
import EditorJS from '@editorjs/editorjs';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change, for consistency within the project.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, this was a required change in order to make editorjs v2.27 work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit header toolSettings levels
2 participants