Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS App Store Release Checklist #541

Open
12 of 38 tasks
benonymity opened this issue Feb 1, 2023 · 27 comments
Open
12 of 38 tasks

iOS App Store Release Checklist #541

benonymity opened this issue Feb 1, 2023 · 27 comments
Labels
enhancement New feature or request

Comments

@benonymity
Copy link
Contributor

benonymity commented Feb 1, 2023

Here is a rough checklist of bugs that should be fixed on the iOS app before it comes out of beta and could go onto the App Store.


There are also many quality of life updates that don't make the app unusable, but would be nice to have. They're incomprehensively listed here:

Features:

Bugs:

@benonymity benonymity added the enhancement New feature or request label Feb 1, 2023
@advplyr advplyr pinned this issue Feb 1, 2023
@advplyr
Copy link
Owner

advplyr commented Feb 1, 2023

For the improve bookmarks bug I don't think that is actually a bug. It wasn't reproducible. Adding offline bookmarking and syncing would be a feature but would be lower priority for release.

The continue listening shelf offline was also not a bug but I closed that one since I added that in the last release. There is one other thing I want to add before coming out of beta which is showing the offline items in the library view. Currently when you are offline you will see nothing in there and all your downloaded media will be on the home page.

Thanks for making this checklist, getting there!

@advplyr
Copy link
Owner

advplyr commented Feb 1, 2023

I just closed #375 and made #163 the main thread for offline bookmarks

@benonymity
Copy link
Contributor Author

Great, updated those two things on the list!

@Jmanko16
Copy link

Jmanko16 commented Feb 2, 2023

Bug, selecting chapter list and going backwards does not actually take you to that chapter, it just resets current chapter to beginning on iOS

@Jmanko16
Copy link

Jmanko16 commented Feb 2, 2023

Consider adding download button for offline playback to app (allow audiobook file or ebook to be downloaded locally and played in another app)

@whmountains
Copy link

I would be in favor of releasing as soon as possible, and adding more features after the app store release. The app is already incredibly useful, and at least one friend has told me that the only thing steering them away from ABS is the lack of a mobile app.

I'm guessing this option was considered and discarded. What was the reason? Perhaps it is easier to iterate faster with testflight.

If the app were released to the store, I would still happily stay on the testflight version to help test new features. Probably many other users would as well. You could release to testflight first, then to the app store a few weeks later after the bugs are worked out.

@advplyr
Copy link
Owner

advplyr commented Feb 3, 2023

I'm okay with releasing before everything on the checklist is complete, but I don't think it is ready to release right now. It's close though.

Once you release you start getting rated and reviewed. Many people are not going to see that this is an early release and under active development, so they will give a negative rating on something we are currently working on.
It's not a big deal since it will be a free app, but still preventable by not rushing out of beta. Having a poorly rated app does detract users if we want people to use the software we've been building.

@vdrover
Copy link

vdrover commented Nov 12, 2023

following, and offering encouragement to release as-is.

@benonymity
Copy link
Contributor Author

Thanks for the bump @vdrover, just updated the list with new features and bugs. I agree that getting a release out sooner would be better, especially judging by the incessant requests for more beta space, but there are a few gamebreaking playback bugs it would probably be bad to publish with. But hopefully a release isn't too far in the future!

@ruoti
Copy link

ruoti commented Nov 12, 2023

I'm willing to help out with this in the coming weeks, once school is out for the break.

However, I think it would be good for the people who have been working on iOS to triage this list. While the bugs seem reasonable to fix before release, many of the features feel like things that could easily wait until a later time. This post is nearly a year old, and based on the number of items in the list, it would seem that the app is farther from release today than it was in February. At this point, more people might be being driven away from audiobookshelf by the lack of an app then would be driven away by a good app with some issues (what it currently is) that gets 4/5 stars in the app store.

@vdrover
Copy link

vdrover commented Nov 12, 2023

Willing to contribute a 5-star rating post-release :)

@vdrover
Copy link

vdrover commented Nov 12, 2023

Just an idea: leave the source code open source and charge a 1-time fee of $2.99 for the app as a "distribution fee". That's totally compatible with the GPL, and could easily cover the apple developer fee at a minimum.

@benonymity
Copy link
Contributor Author

@ruoti good point, I've now separated this list into a release section and nice QoL updates. Especially since some of the bugs are only affecting a few people it might not be reasonable to wait on them for a release that is affecting a lot of people. I'll also put some time in over the holiday break to try and fix some of the bigger bugs.

@advplyr
Copy link
Owner

advplyr commented Nov 13, 2023

Thanks everyone for the comments and @benonymity for keeping a running checklist.

I would say the main blocker for iOS right now is the bugs. We are getting a lot of reports, especially in Discord, about the media player closing when the phone is asleep and you pause with bluetooth.
I haven't been able to reproduce that but I removed some background activity yesterday from the iOS side so hopefully someone can build from source and check if that is still a bug.

Maybe iOS made some recent changes that kills background tasks.
Android has similar issues to overcome with background tasks getting killed, mostly by the battery optimization logic.

@gh0sti
Copy link

gh0sti commented Nov 13, 2023

following, and offering encouragement to release as-is.

I would not release until we know for sure that the pause/resume function works. This is a very frustrating experience on iOS users when streaming/playing from download and pausing the book for more than 5 seconds kills the app and the playback session until you reopen the app. @advplyr says he has a fix but the users who have said this is an issue really should test this to make sure it's ready to go. I believe this is a show stopper until resolved with feedback.

@advplyr
Copy link
Owner

advplyr commented Nov 13, 2023

I don't have a fix because I haven't been able to reproduce the issue, but I did make some updates.

@vdrover
Copy link

vdrover commented Nov 14, 2023

I experience the issue (not a blocker for releasing for me as progress is saved), but happy to test. I have version 0.9.66 currently.

@TeroKeso
Copy link

TeroKeso commented Dec 2, 2023

I just bought an iPhone 15 alongside Android. If there have been no differences between sideloading vs testflight, then I can try to reproduce the problems. playback issues are familiar from the early days of the Android app

@advplyr
Copy link
Owner

advplyr commented Dec 4, 2023

I want to add that I think we need to better handle playback errors before the release. This is commonly reported as an Abs bug when the audio file cannot be played on the device. I opened an issue for it #968

@gh0sti
Copy link

gh0sti commented Dec 5, 2023

I want to add that I think we need to better handle playback errors before the release. This is commonly reported as an Abs bug when the audio file cannot be played on the device. I opened an issue for it #968

since either using ABS to convert multi mp3s to m4b or just adding m4bs from elsewhere I haven't come accross this issue on iOS. Is this due to quality of the audio file such as flac ect?

@vdrover
Copy link

vdrover commented Dec 10, 2023

Seems you're getting closer. Any estimate for release?

@jvik
Copy link

jvik commented Jan 15, 2024

FYI: I've been using the iOS Beta for a year now, and it has been working flawless for me through ~200 hours. In my opinion it is more than stable enough for a production release and I would gladly pay for it.

@TheUncannyObserver
Copy link

I would also be willing to pay for this once it releases. I use the mobile view every day from Safari, but a native app would be much better.

@nigiriemoji
Copy link

Can you please add issue #973 to the list of bugs for iOS checklist? I feel like this is going to be a common bug for many iOS 17 and newer users

@benonymity
Copy link
Contributor Author

Done. I think right now #973 is probably the most obvious barrier to release. Can't speak for everyone, but I encounter it on an almost daily basis. When I have some time I'll try to see what if anything changed in either the ABS code or iOS 17 that broke playback so blatantly—it should hopefully be a simple solution.

@indiefan
Copy link
Contributor

Regarding #973, I’m curious if the change was related to defaultRate (and thus fixed by recent pull request). @benonymity if you’re encountering it so frequently, can you try using a build from head which includes that fix and see if it still happens? (Not sure how long it takes for changes to make it into the test flight build)

@harupong
Copy link

I tried iOS app v0.9.74-beta with iOS17 installed iPhone, and #973 seems to be fixed. Thanks a lot for a great contribution, @indiefan !!
Can't wait for the official release to the App Store 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests