Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating bookmarks for offline media #163

Open
raketenhunddev opened this issue May 2, 2022 · 8 comments
Open

Creating bookmarks for offline media #163

raketenhunddev opened this issue May 2, 2022 · 8 comments
Labels
bug Something isn't working

Comments

@raketenhunddev
Copy link

Steps to reproduce

  1. Download audiobook
  2. Start local playback
  3. Create a bookmark

Expected behaviour

  • I can create a bookmark which is in sync with the server

Actual behaviour

  • The bookmark button is missing. It is visible for online media but not for offline media.

Environment data

Audiobookshelf Version: 2.0.8

  • [ x] Android App? 0.9.43-beta

Android Issue

Android version: 12

Device model: Galaxy S21

Stock or customized system: stock

@raketenhunddev raketenhunddev added the bug Something isn't working label May 2, 2022
@advplyr
Copy link
Owner

advplyr commented May 7, 2022

In v0.9.44-beta if you are connected to the server you downloaded the item from then bookmarks will be available.
Bookmarks are not yet implemented when not connected to the server, that could be a while since it is a big effort.

@kaldigo
Copy link

kaldigo commented Jun 10, 2022

I am still having this problem even on 0.9.49

@cinvan2000
Copy link

I am still having this issue as well on 0.9.51-beta.

Audiobookshelf Version: 2.0.24

Android version: 11

Device model: OnePlus 6

@advplyr
Copy link
Owner

advplyr commented Jul 31, 2022

Downloaded library items have to be linked to a server item for them to show bookmarks and you have to be connected to the same server they are linked.

@kaldigo
Copy link

kaldigo commented Oct 8, 2022

They are linked and on the book details page it does say its connected. On the player at the top it says local and there is no option for bookmarks. The button for them is just missing.

Screenshot_20221008_114552_audiobookshelf.jpg
Screenshot_20221008_114727_audiobookshelf.jpg

@advplyr
Copy link
Owner

advplyr commented Dec 13, 2022

Fixed the bug where bookmarks weren't showing for downloaded media when currently connected to server in v0.9.60-beta

We can leave this open for supporting completely offline bookmarks.

@mym0T
Copy link

mym0T commented Feb 1, 2023

Fixed the bug where bookmarks weren't showing for downloaded media when currently connected to server in v0.9.60-beta

We can leave this open for supporting completely offline bookmarks.

I'm still having this issue in v0.9.61-beta on iOS

To replicate the issue:

  1. Play the book while connected to the server and the bookmark button is visible
    image

  2. Fully close/kill the app

  3. Re-open the app and allow it to connect to the server
    image

  4. The book that was previously playing will show in the bar at the bottom with the progress and play button. Tap that bar to view the now playing window, and the bookmarks button will not be visible.
    image
    image

To make the button appear again, you can either:

  1. Start playing a different book, then return to the current book.
  2. Tap the 3 dots at the top right corner of the now playing screen, tap close player, then tap the play button on the book again to re-open it.
    image

@advplyr
Copy link
Owner

advplyr commented Feb 1, 2023

Oh I see, this is specific to iOS and opening the playback session before the server connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants