Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light theme #916

Closed
schwartzaher opened this issue Oct 18, 2023 · 11 comments
Closed

Light theme #916

schwartzaher opened this issue Oct 18, 2023 · 11 comments
Labels
enhancement New feature or request

Comments

@schwartzaher
Copy link

I was trying to use the app on my Onyx Boox Poke 4 Lite. Love how the reader portion of the app looks. Navigation throughout reading a book looks and functions very amazing. It is the first app and server that I found that can replace the built in book reader on my e-reader. The only problem I have is the dark mode. When you navigate the main page of the bookshelf, the screen becomes very dark and is very hard to navigate and see. Having a light mode would make that so much easier to navigate and make the app worth it. I was using it for a week to see if I could work around it, having to stop just because of not being able to navigate my books in the bookshelf mode. Adding a light mode would make this look and work a lot nicer on any device that uses an e-ink screen. Using the app and dark mode on my tablet looks fine as it is an IPS LCD display that looks just fine with dark mode.

@schwartzaher schwartzaher added the enhancement New feature or request label Oct 18, 2023
@advplyr
Copy link
Owner

advplyr commented Oct 18, 2023

Can you share a picture of what this looks like for you on that device?

@schwartzaher
Copy link
Author

IMG_20231018_233239_002
IMG_20231018_233204_575

@schwartzaher
Copy link
Author

This is with a manual screen refresh to give it the best possible look. With dark mode it seems to kill the bookshelf but book itself looks good.

@KaiStarkk
Copy link
Contributor

KaiStarkk commented Dec 9, 2023

Same on the Boox Air 3 C with colour epaper. Seems like dark apps cause more refreshes

The other things that would be amazing for e-readers:

  • option to hide the player bar at bottom of screen but keep playing (the MM:SS updates
  • Tap left/right to turn page and disable swipes (can conflict with ereader gestures)
  • Instant page change option instead of turn animation
  • Continuous vertical scroll option (again disabling side swipes)
  • separate download button for ebook only
  • Ability to change columns, margins, and font (Caecilia condensed is popular, although I already like ABS default)

@advplyr I thought I recall there used to be a tap option? - apologies if I’m missing it

IMG_0794
IMG_0793

@advplyr
Copy link
Owner

advplyr commented Dec 12, 2023

Next release will include the first pass at light theme. I'm still going through and finding things I missed but it will be setup so that we can change the colors easily.

image

The track bar is still using the dark theme, need to update that.

@benonymity
Copy link
Contributor

This looks awesome, love the color selection!

@advplyr
Copy link
Owner

advplyr commented Dec 19, 2023

Added in 0.9.69-beta

@advplyr advplyr closed this as completed Dec 19, 2023
@advplyr
Copy link
Owner

advplyr commented Dec 19, 2023

If you test this out on your ereader please share a screenshot of what it looks like now

@schwartzaher
Copy link
Author

IMG_20231219_202738_362
IMG_20231219_202835_417
IMG_20231219_202920_808
IMG_20231219_202925_118
IMG_20231219_202936_813

So it looks good. Haven't used it since I posted this issue. It looks resolved, not being able to use bookshelf view which is to be expected. I still need to customize the font and other things. Otherwise it looks good.

@schwartzaher
Copy link
Author

IMG_20231219_202738_362 IMG_20231219_202835_417 IMG_20231219_202920_808 IMG_20231219_202925_118 IMG_20231219_202936_813

So it looks good. Haven't used it since I posted this issue. It looks resolved, not being able to use bookshelf view which is to be expected. I still need to customize the font and other things. Otherwise it looks good.

At this point it looks good. I'm not sure how easy it is to program a toggle that asks if you want to switch off of bookshelf mode when you turn on light mode. Otherwise thank you for fixing things

@advplyr
Copy link
Owner

advplyr commented Dec 19, 2023

Awesome thanks for the photos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants