Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added alternative view setting #299

Merged
merged 8 commits into from
Jul 27, 2022
Merged

Added alternative view setting #299

merged 8 commits into from
Jul 27, 2022

Conversation

samblooms
Copy link

This adds a device setting that will act similarly to the 'Alternative Bookshelf View' toggle on the web version. A toggle switch added to the settings page will change the shelf color, shelf background, and text color on the labels to match the alternate style.

  • Changing the label style on the series page ( LazySeriesCard.vue ) is buggy.
    Using the same 'v-bind:class' and a method to return either 'shinyBlack' or 'altBookshelfLabel' breaks the loading of series.

@advplyr
Copy link
Owner

advplyr commented Jul 27, 2022

The alternate bookshelf view in the web app shows the title/author under the LazyBookCard
image

I think we should implement it this way and use the regular bg instead of importing the texture. What to you think?
I'm going to push some commits here

@advplyr
Copy link
Owner

advplyr commented Jul 27, 2022

I made everything look like the web app except I kept in your altBookshelfLabel for series and collections pages. I think it looks nice thanks for contributing.

@advplyr advplyr merged commit 3d64c42 into advplyr:master Jul 27, 2022
@samblooms
Copy link
Author

Wow. I totally overlooked that bit with the title/author. It was kind of a spur of the moment "change the look" type deal at first.
That's definitely a more elegant solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants