App info in account settings #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the account settings view, trying to make it look a bit cleaner by: - Making the logout button look more like a button. The full width looked odd on large devices or in landscape mode. - Removing the version number. It is already listed in the main menu anyway. - Moving the hint about reporting bugs and the GitHub link to the bottom. The hint is still a bit weird in this view. Maybe long-term, we want to move all these information about the app (version, issues, …) to a separate view. But that's something for another day.
|
Looks great, thanks! |
|
Just make sure the text at the bottom isn't covered by the now playing bar. |
|
Checked that, all good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the account settings view, trying to make it look a bit cleaner by:
The hint is still a bit weird in this view. Maybe long-term, we want to move all these information about the app (version, issues, …) to a separate view. But that's something for another day.