Simplify progress (re)sets #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is a follow up to the discussion from advplyr#559 about potentially simplifying progress interactions. This patch essentially reduces the interactions to two simple options which allow users to always marks books as finished or discard the progress and thus mark them as not yet started with a single interaction: - If users have already listed to the book, regardless of the state of the progress (finished, half way through, …), they get an option to discard the progress. This replaces the additional “mark as not finished” option but it should still be clear to users what happens. - If a book is not yet finished, regardless of the state of the progress (not yet started, half way through), users get a “mark as finished” option which sets the progress to 100%. This is hopefully a bit simpler than what we have now but also doesn't require a user to figure out that you need to first mark a book as finished to be able to discard the progress.
|
I like it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a follow up to the discussion from #559 about potentially simplifying progress interactions.
This patch essentially reduces the interactions to two simple options which allow users to always marks books as finished or discard the progress and thus mark them as not yet started with a single interaction:
If users have already listed to the book, regardless of the state of the progress (finished, halfway through, …), they get an option to discard the progress. This replaces the additional “mark as not finished” option, but it should still be clear to users what happens.
If a book is not yet finished, regardless of the state of the progress (not yet started, halfway through), users get a “mark as finished” option which sets the progress to 100%.
This is hopefully a bit simpler than what we have now but also doesn't require a user to figure out that you need to first mark a book as finished to be able to discard the progress.