Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: iTunes match authors include & and not splitting correctly #1022

Closed
Hallo951 opened this issue Sep 29, 2022 · 7 comments
Closed

[Bug]: iTunes match authors include & and not splitting correctly #1022

Hallo951 opened this issue Sep 29, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@Hallo951
Copy link
Contributor

Describe the issue

If I scrape an audiobook and the authors are not separated by a comma but by a & (e.g. Author1 & Author2), it does not recognize the individual authors and interprets the expression as 1 author. If they are separated by a comma the interpretation works correctly. I noticed this especially with the itune scrapper.

Steps to reproduce the issue

  1. scrapping a audiobook with 2 autors ans the itune scrapper

Audiobookshelf version

current

How are you running audiobookshelf?

Docker

@Hallo951 Hallo951 added the bug Something isn't working label Sep 29, 2022
@advplyr
Copy link
Owner

advplyr commented Sep 29, 2022

Do you have an example book where the author is separated by &?

@Hallo951
Copy link
Contributor Author

Hallo951 commented Oct 3, 2022

Here is an example:

Screenshot_20221003_213117_com brave browser
Screenshot_20221003_213132_com brave browser

@advplyr
Copy link
Owner

advplyr commented Oct 4, 2022

I don't think Audible or Google books formats their authors this way. With Audible/Google books they give us back an array of authors whereas iTunes gives us back one string with authors.
Were you able to come across this with Google books or Audible?

For iTunes I suppose we could add an additional step to split on the "&". Seems a bit scrappy though.

@advplyr advplyr changed the title [Bug]: Small error when scrapping [Bug]: iTunes match authors include & and not splitting correctly Oct 4, 2022
@advplyr
Copy link
Owner

advplyr commented Oct 4, 2022

I ended up just implementing the split on & for iTunes results. We'll see how that goes.

@Hallo951
Copy link
Contributor Author

Hallo951 commented Oct 5, 2022

No, this does not apply in audible and google books. Everything works as it should. I only noticed this because I once did something with itunes and strange authors came out there.

Great, thank you very much. I still have a lot of audiobooks to scrap, so I'm happy to test that then. Can I download the new version somewhere?

@advplyr
Copy link
Owner

advplyr commented Oct 5, 2022

This will be in the next server release probably this weekend.

@advplyr
Copy link
Owner

advplyr commented Oct 8, 2022

Updated in v2.2.1

@advplyr advplyr closed this as completed Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants