Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: "Save metadata with item" has no effect #1952

Closed
theS1LV3R opened this issue Jul 22, 2023 · 1 comment
Closed

[Bug]: "Save metadata with item" has no effect #1952

theS1LV3R opened this issue Jul 22, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@theS1LV3R
Copy link

theS1LV3R commented Jul 22, 2023 •
edited

Describe the issue

Metadata is never saved to file, regardless of the value of the option "Save metadata with item" or "Metadata File Format".

Possible reason could be that LibraryItem.saveMetadata is never called anywhere in the codebase. See this search.

Steps to reproduce the issue

  1. Fresh install, have books or audiobooks
  2. Set up library, enable "Save metadata with item"
  3. Scan library, observe how no metadata files are created.

Audiobookshelf version

v.2.3.3

How are you running audiobookshelf?

Docker

edit was cuz I thought I had missed a result, turns out it was actually the bug being fixed, ignore the edits
@theS1LV3R theS1LV3R added the bug Something isn't working label Jul 22, 2023
advplyr added a commit that referenced this issue Jul 22, 2023
@advplyr
Fix:Save metadata files when updating library items #1952
80aea0c
@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Jul 22, 2023
@advplyr advplyr mentioned this issue Aug 26, 2023
Closed
@advplyr
Copy link
Owner

advplyr commented Sep 9, 2023

Fixed in v2.4.0

@advplyr advplyr closed this as completed Sep 9, 2023
@advplyr advplyr removed the awaiting release Issue is resolved and will be in the next release label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theS1LV3R @advplyr