[Bug]: Invalid cover path crashes container

[engirugger42]

Describe the issue

Editing the cover path to a directory causes the container to crash. Visually, the web app just shows the socket connection failed. I have also tested this with non-image files and files that do not exist, both of these cases are handled correctly. Logs attached.
audiobookshelf-logs.txt
Edit: Debug logs
audiobookshelf-debug-logs.txt

Steps to reproduce the issue

1. Go to any audio book, with or without cover art.
2. Click the edit cover art button.
3. Change to the path to a directory
4. Click Save

Audiobookshelf version

2.3.3

How are you running audiobookshelf?

Docker

[advplyr]

The error log isn't giving us anything useful to go off of. I just tested putting in a bad path, putting in a good path, and putting in a URL to an image. All of those worked properly.

When putting in a path that doesn't exist the server shows this error:

[2023-08-23 17:40:22] ERROR: [CoverManager] validate cover path does not exist "/path/that/does/not/exist/test.png" (CoverManager.js:185)

And I get

Can you give more specific details on how to reproduce this error?

[engirugger42]

Sure thing. Specifically, a path ending in a directory with a / is what broke it for me. Visual example:

Hitting save at this point will cause a socket disconnect. I just recreated this to get double check, and the container managed to recover, which is not what I observed 2 weeks ago. I have not changed versions in that time, so perhaps I just wasn't patient enough with the container before or my server was just having an off day, in which case this can be closed.

For what its worth, I did some digging in the repo and I believe it's coming from this method in fileUtils when called from this method in CoverManager. I've never been much of a JS guy, much less using the larger frameworks, so apologies if that's not a particularly helpful suggestion.

[advplyr]

I was able to reproduce this. It is specific to entering a file path that exists but is not a file. I fixed it by checking that the path is a file and not a directory.

[advplyr]

Fixed in v2.4.0