[Bug]: RSS Feeds not respecting "Prevent feed from being indexed by itunes and google"

[DieselTech]

Describe the issue

Turning on Prevent feed from being indexed by itunes and google doesn't apply the protections it says it does. This is confirmed both by the RSS status window showing "Prevent Indexing: No" and by checking the RSS feed itself.

<itunes:block>No</itunes:block>
<googleplay:block>no</googleplay:block>

Steps to reproduce the issue

1. Turn on a feed
2. Check the box to prevent
3. View Feed

Audiobookshelf version

2.3.3

How are you running audiobookshelf?

Docker

[advplyr]

I wasn't able to reproduce this in my testing. With the prevent indexing checked I get:

<itunes:block>Yes</itunes:block>
<googleplay:block>yes</googleplay:block>

I did some reading on this though and made minor updates. I updated them to use lowercase "yes" and when not preventing indexing those tags won't be present at all. Using "no" in that tag is useless.

Are you still able to reproduce this on 2.3.3?

[DieselTech]

Are you still able to reproduce this on 2.3.3?

Yes. I even turned off existing feeds that were made on prior versions and recreated them on 2.3.3

The behavior is 100% reproducible on my instance using the latest docker container.

[advplyr]

Are you able to get it to say "Yes" here at all?

[DieselTech]

Are you able to get it to say "Yes" here at all?

Nope. No combo of actions I could take would ever get it to show up as Yes

[nichwall]

I was just able to recreate this using a collection on 5c1c511 (edge on October 27 2023, most recent release was 2.4.4). When opening an RSS feed from a single book the Prevent Indexing was set correctly, but was not set for a collection with two books.

[advplyr]

Thanks, I found it. It was specific to collections & series

[advplyr]

Fixed in v2.5.0